[Infra UI] Stop click propagation on tooltip #161565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
crespocarlos
added
Feature:Metrics UI
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
neptunian
approved these changes
Jul 10, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 10, 2023
fixes [elastic#161553](elastic#161553) ## Summary Fixes click event on the tooltip content https://github.com/elastic/kibana/assets/2767137/13c8fde1-7dfe-4fb0-92f2-b3e45bd36972 ### How to test - Start a local Kibana instance - Navigate to `Infrastructure` > `Hosts` - Click on the `?` icon in the table column headers and then click on the content. It must not sort the table (cherry picked from commit 6c2170d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 10, 2023
# Backport This will backport the following commits from `main` to `8.9`: - [[Infra UI] Stop click propagation on tooltip (#161565)](#161565) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-10T17:32:11Z","message":"[Infra UI] Stop click propagation on tooltip (#161565)\n\nfixes [#161553](https://github.com/elastic/kibana/issues/161553)\r\n\r\n## Summary\r\n\r\nFixes click event on the tooltip content\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/2767137/13c8fde1-7dfe-4fb0-92f2-b3e45bd36972\r\n\r\n\r\n### How to test\r\n\r\n- Start a local Kibana instance\r\n- Navigate to `Infrastructure` > `Hosts`\r\n- Click on the `?` icon in the table column headers and then click on\r\nthe content. It must not sort the table","sha":"6c2170d3856360f25371d30d14b0b0efaf48252f","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Metrics UI","Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","Feature:ObsHosts","v8.9.0","v8.10.0"],"number":161565,"url":"https://github.com/elastic/kibana/pull/161565","mergeCommit":{"message":"[Infra UI] Stop click propagation on tooltip (#161565)\n\nfixes [#161553](https://github.com/elastic/kibana/issues/161553)\r\n\r\n## Summary\r\n\r\nFixes click event on the tooltip content\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/2767137/13c8fde1-7dfe-4fb0-92f2-b3e45bd36972\r\n\r\n\r\n### How to test\r\n\r\n- Start a local Kibana instance\r\n- Navigate to `Infrastructure` > `Hosts`\r\n- Click on the `?` icon in the table column headers and then click on\r\nthe content. It must not sort the table","sha":"6c2170d3856360f25371d30d14b0b0efaf48252f"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161565","number":161565,"mergeCommit":{"message":"[Infra UI] Stop click propagation on tooltip (#161565)\n\nfixes [#161553](https://github.com/elastic/kibana/issues/161553)\r\n\r\n## Summary\r\n\r\nFixes click event on the tooltip content\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/2767137/13c8fde1-7dfe-4fb0-92f2-b3e45bd36972\r\n\r\n\r\n### How to test\r\n\r\n- Start a local Kibana instance\r\n- Navigate to `Infrastructure` > `Hosts`\r\n- Click on the `?` icon in the table column headers and then click on\r\nthe content. It must not sort the table","sha":"6c2170d3856360f25371d30d14b0b0efaf48252f"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #161553
Summary
Fixes click event on the tooltip content
tooltip_fix.mov
How to test
Infrastructure>Hosts?icon in the table column headers and then click on the content. It must not sort the table